Add swift-log #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved start method for bottstrapping into a new file. - Aligned Logger to the log levels.
This is for if the API user doesn't add the bundle identifier of the project.
This code isn't working, so it'll be commented out until a better solution arrives. For now, a Swift package already works, but the ideal thing is to have one less dependency from logs (using `SwiftLog`, however, is unavoidable).
Trying to add the LoggingOSLog works. However, this Swift package, for whatever reason, is refusing to see the LoggingOSLog package. For now, the files and licence will be added directly into the project until a different solution appears.
Also fixed a documentation issue in AtprotoLabelDefinition.
Also added documentation for an example.
LoggingOSLog doesn't see to be working and its making SwiftLog crash. An in-house solution will be used instead.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds logging functionality to ATProtoKit. This uses
SwiftLogwhich will bootstrapOSLogand will determine if it should be used or not depending on whether the platform can importos. This pull request will be complete upon the following tasks and will be in phases:Phase 1:
OSLogATProtoKitConfiguration-conforming classes for anything related to logging.Phase 2:
APIClentServicePhase 3:
ATDataStreamConfigurationDateFormattingATFacetParserATImageProcessingLinked Issues
Link any related issues here. Format:
#[issue number]#7
Type of Change
Checklist:
Screenshots (if applicable)
N/A
Additional Notes
When this is completed, issue #7 will close.
Credits
If you want to be credited in the CONTRIBUTORS file, you can fill out the form below. Please don't remove the square brackets.